Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Jan 20, 2022

No description provided.

@kszucs kszucs changed the title [Release][Crossbow] Fall back to 0 distance when generating scm version ARROW-15393: [Release][Crossbow] Fall back to <version>dev0 when the generated scm version number doesn't have a distance Jan 20, 2022
echo "Installed miniconda at ${MINICONDA}"

. $MINICONDA/etc/profile.d/conda.sh
conda activate base
Copy link
Member Author

@kszucs kszucs Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On macOS I had to activate the base conda environment before using mamba.

major += 1

return "{}.{}.{}.dev{}".format(major, minor, patch, version.distance)
return "{}.{}.{}.dev{}".format(major, minor, patch, version.distance or 0)
Copy link
Member Author

@kszucs kszucs Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably due to the release branch: the latest tag on the release branch is not reachable from the PR's master's HEAD commit.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kszucs You can merge this at any time you like.

@kszucs kszucs closed this in 6b0ce27 Jan 20, 2022
@ursabot
Copy link

ursabot commented Jan 20, 2022

Benchmark runs are scheduled for baseline = d49e216 and contender = 6b0ce27. 6b0ce27 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.13%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants