-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15393: [Release][Crossbow] Fall back to <version>dev0 when the generated scm version number doesn't have a distance #12210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| echo "Installed miniconda at ${MINICONDA}" | ||
|
|
||
| . $MINICONDA/etc/profile.d/conda.sh | ||
| conda activate base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On macOS I had to activate the base conda environment before using mamba.
| major += 1 | ||
|
|
||
| return "{}.{}.{}.dev{}".format(major, minor, patch, version.distance) | ||
| return "{}.{}.{}.dev{}".format(major, minor, patch, version.distance or 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably due to the release branch: the latest tag on the release branch is not reachable from the PR's master's HEAD commit.
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
|
|
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@kszucs You can merge this at any time you like.
|
Benchmark runs are scheduled for baseline = d49e216 and contender = 6b0ce27. 6b0ce27 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.